On 10/27/2015 01:46 PM, Denys Vlasenko wrote: > This function compiles to 98 bytes of machine code. This looks ok because these function are heavyweight. You'll want to add men_z135_reg_set() to this patch as well, and please cc the driver author: Johannes Thumshirn <johannes.thumshirn@xxxxxx> Regards, Peter Hurley > Signed-off-by: Denys Vlasenko <dvlasenk@xxxxxxxxxx> > CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > CC: Peter Hurley <peter@xxxxxxxxxxxxxxxxxx> > CC: Jiri Slaby <jslaby@xxxxxxxx> > CC: linux-serial@xxxxxxxxxxxxxxx > --- > drivers/tty/serial/men_z135_uart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/men_z135_uart.c b/drivers/tty/serial/men_z135_uart.c > index b90e7b3..2b5b66f 100644 > --- a/drivers/tty/serial/men_z135_uart.c > +++ b/drivers/tty/serial/men_z135_uart.c > @@ -159,7 +159,7 @@ static inline void men_z135_reg_set(struct men_z135_port *uart, > * @addr: Register address > * @val: value to clear > */ > -static inline void men_z135_reg_clr(struct men_z135_port *uart, > +static void men_z135_reg_clr(struct men_z135_port *uart, > u32 addr, u32 val) > { > struct uart_port *port = &uart->port; > -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html