On Thursday 01 October 2015 19:16:16 Scott Wood wrote: > > +#ifdef CONFIG_SERIAL_8250_FSL > + if (of_device_is_compatible(np, "fsl,ns16550") || > + of_device_is_compatible(np, "fsl,16550-FIFO64")) > + port->handle_irq = fsl8250_handle_irq; > +#endif > + > Can you change this to use if (IS_ENABLED(CONFIG_SERIAL_8250_FSL)) && ... The resulting code will be the same, it just get a little easier on the eye. Other than that, I wonder if we should do this completely differently and have the respective entries in of_platform_serial_table[] with an appropriate PORT_* constant to handle the freescale case. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
