Hi Alexander, On 01.10.2015 10:42, Alexander Shiyan wrote: >> Среда, 30 сентября 2015, 23:57 +03:00 от Vladimir Zapolskiy <vz@xxxxxxxxx>: >> >> Hardcode IC irq type to IRQF_TRIGGER_FALLING for both platform and OF >> cases. According to the datasheet IC irq line is active low, reflect >> this fact in the driver. > > Hello. > > On my opinion, the better way is use IRQ_TYPE_LEVEL_* definitions in the second > interrupt cell in DTS. The interrupt line can be connected through external invertor, > so we can handle all possible situations. the external inverter you are talking about is a separate piece of hardware, and in my opinion there is no need to describe its hypothetical presence on board in the sc16is7xx device driver. -- With best wishes, Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
