Re: [PATCH] tty: sc16is7xx: Fix per-channel rx/tx buffer access

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 24 Sep 2015 14:54:40 +0200, Florian Achleitner wrote:
> Register access must encode the channel of this multi-channel device
> in the lowest nibble of the register address.
> 
> This is done correctly most of the time, but not when reading/writing
> the fifo in handle_tx/rx. It worked by fortune for channel 0, because
> the address happens to be 0x0, but not for any other channel.
> 
> Fix this bug, and add a macro to encapsulate the address encoding, and use
> it everywhere.
> 
> Signed-off-by: Florian Achleitner <achleitner.florian@xxxxxxxxxxx>

Should be fixed already by:

commit dec273ecc1169ade46999bb0feca3814915f5c11
Author: Bo Svangård <bo.svangard@xxxxxxxxxxxxxx>
Date:   Sat Jun 13 13:40:20 2015 +0200

    sc16is7xx: fix FIFO address of secondary UART
    
    Calls to regmap_raw_read/write needed register rewrite in a
    similar way as function calls to regmap_read/write already had.
    This enables reading/writing the serial datastream to the device.

Please try with latest code.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux