Hello Greg, I'd like the serial driver to support my platform, and am soliciting your input for the best course of action. I discussed some aspects of this topic back in March. Message-ID: <54F9BE90.3000609@xxxxxxx> Subject: Misc questions about 8250_core.c (I would provide a gmane link, but it appears they stopped archiving linux-serial 10 months ago.) https://marc.info/?l=linux-serial&m=142565339809403&w=2 My platform has the same semi-standard register layout as MIPS_ALCHEMY and SERIAL_8250_RT288X. The code supporting this layout is conditionally compiled (cf. drivers/tty/serial/8250/8250_core.c) #if defined(CONFIG_MIPS_ALCHEMY) || defined(CONFIG_SERIAL_8250_RT288X) ... #endif As far as I can see, there are two (fairly simple) solutions: 1) I can define SERIAL_8250_RT288X for my platform 2) I can add || defined(CONFIG_MY_PLATFORM) Doing /just/ solution #1 makes Kconfig unhappy :-) warning: (ARCH_TANGO) selects SERIAL_8250_RT288X which has unmet direct dependencies (TTY && HAS_IOMEM && SERIAL_8250 && (SOC_RT288X || SOC_RT305X || SOC_RT3883 || SOC_MT7620)) So I would also have to edit the dependency rule for SERIAL_8250_RT288X. config SERIAL_8250_RT288X bool "Ralink RT288x/RT305x/RT3662/RT3883 serial port support" depends on SERIAL_8250 && (SOC_RT288X || SOC_RT305X || SOC_RT3883 || SOC_MT7620) help If you have a Ralink RT288x/RT305x SoC based board and want to use the serial port, say Y to this option. The driver can handle up to 2 serial ports. If unsure, say N. Is solution #2 the preferred solution? Or is there another better way? Regards. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
