On Wed, Sep 16, 2015 at 4:30 AM, Heikki Krogerus
<heikki.krogerus@xxxxxxxxxxxxxxx> wrote:
> On Tue, Sep 15, 2015 at 04:29:45PM +0300, Andy Shevchenko wrote:
>> > unsigned skip_autocfg:1;
>> > + unsigned uart_16550_compatible:1;
>>
>> Perhaps to follow the style of 8250? Is it okay to use plain 'unsigned'
>> here?
>
> In 8250_core there are no bit field variables like that. I copied the
> style from some other driver like dwc3:
> drivers/usb/dwc3/core.h
>
> I can change it if there is some problem with using just "unsigned".
> Otherwise let's just keep it like that.
>
>> > + id = acpi_match_device(p->dev->driver
>> > ->acpi_match_table, p->dev);
>> > + if ((id && strcmp(id->id, "AMD0020") &&
>> > + strcmp(id->id, "APMC0D08")) || !id) {
>>
>> Shouldn't we ask the actual owners of such devices if they have the
>> Busy Functionality enabled?
>
> Yes. Now this check will simply ensure that the behaviour on those
> platforms is the same as before. But in any case, like you said, let's
> get the confirmation.
>
> Ken, Feng! Could you tell us if the DW_apb_uart on your platforms has
> the Busy Functionality or not (UART_16550_COMPATIBLE)?
The DW_apb_uart is 16550 compatible, which means the "Busy" functionality
is not implemented.
>
>> Otherwise can we use string array to match with?
>
> For two ids I don't think that is necessary. If there are more, we can
> see if it's reasonable to add it for this check.
>
>
> Thanks Andy,
>
> --
> heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
