Hi Noam, On 08/12/2015 07:18 AM, Noam Camus wrote: > From: Noam Camus <noamc@xxxxxxxxxx> > > Add support for OF option "no-loopback-test" > > use case: simulator which does not implements loopback test mode. I think Greg's question about the simulator still applies: why upstream this? The simulator is not even identified so how is someone supposed to know this workaround applies? The fact there are no in-tree DT users of this workaround argues against its acceptance. Regards, Peter Hurley > Signed-off-by: Noam Camus <noamc@xxxxxxxxxx> > --- > .../bindings/serial/snps-dw-apb-uart.txt | 2 ++ > drivers/tty/serial/8250/8250_dw.c | 3 +++ > 2 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.txt b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.txt > index 289c40e..5d16047 100644 > --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.txt > +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.txt > @@ -33,6 +33,8 @@ Optional properties: > - ri-override : Override the RI modem status signal. This signal will always be > reported as inactive instead of being obtained from the modem status register. > Define this if your serial port does not use this pin. > +- no-loopback-test: set to indicate that the port does not implements loopback > + test mode > > Example: > > diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c > index 62f766a..0f397ae 100644 > --- a/drivers/tty/serial/8250/8250_dw.c > +++ b/drivers/tty/serial/8250/8250_dw.c > @@ -394,6 +394,9 @@ static int dw8250_probe_of(struct uart_port *p, > up->dma->txconf.dst_maxburst = p->fifosize / 4; > } > > + if (of_find_property(np, "no-loopback-test", NULL)) > + p->flags |= UPF_SKIP_TEST; > + > if (!of_property_read_u32(np, "reg-shift", &val)) > p->regshift = val; > > -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
