[Re: [PATCH 5/5] drivers/tty: make serial 8250_lpc18xx.c explicitly non-modular] On 10/08/2015 (Mon 20:42) Joachim Eastwood wrote: > Hi Paul, > > On 9 August 2015 at 02:51, Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> wrote: > > The Kconfig currently controlling compilation of this code is: > > > > 8250/Kconfig:config SERIAL_8250_LPC18XX > > 8250/Kconfig: bool "NXP LPC18xx/43xx serial port support" > > > > ...meaning that it currently is not being built as a module by anyone. > > > > Lets remove the modular code that is essentially orphaned, so that > > when reading the driver there is no doubt it is builtin-only. > > The bool in KConfig is more or less a copy-paste mistake on my side. I > really meant for this driver to be buildable as module and it builds > just fine with 'm'. > > Want me send a patch changing it to tristate or will you handle it? I will do a v2 in the next day or so with collected ACKs and this patch replaced, unless Greg jumps in and indicates he'd like something different. Paul. -- > > > regards, Joachim Eastwood -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html