Hi Shenwei,
On Thu, Jul 30, 2015 at 11:32 AM, Shenwei Wang
<shenwei.wang@xxxxxxxxxxxxx> wrote:
> +static int imx_serial_port_suspend_noirq(struct device *dev)
> +{
> + struct platform_device *pdev = to_platform_device(dev);
> + struct imx_port *sport = platform_get_drvdata(pdev);
> + int ret;
> +
> + ret = clk_enable(sport->clk_ipg);
> + if (ret)
> + dev_err(dev, "UART%d suspend error!\r\n", sport->port.line);
In case of error you should propagate it:
ret = clk_enable(sport->clk_ipg);
if (ret)
return ret;
> +
> + /* Save necessary regs */
> + sport->saved_reg[0] = readl(sport->port.membase + UCR1);
> + sport->saved_reg[1] = readl(sport->port.membase + UCR2);
> + sport->saved_reg[2] = readl(sport->port.membase + UCR3);
> + sport->saved_reg[3] = readl(sport->port.membase + UCR4);
> + sport->saved_reg[4] = readl(sport->port.membase + UFCR);
> + sport->saved_reg[5] = readl(sport->port.membase + UESC);
> + sport->saved_reg[6] = readl(sport->port.membase + UTIM);
> + sport->saved_reg[7] = readl(sport->port.membase + UBIR);
> + sport->saved_reg[8] = readl(sport->port.membase + UBMR);
> + sport->saved_reg[9] = readl(sport->port.membase + IMX21_UTS);
> +
> + if (ret == 0)
> + clk_disable(sport->clk_ipg);
then you don't need to check ret here. Just call clk_disable unconditionally.
> +
> + return 0;
> +}
> +
> +static int imx_serial_port_resume_noirq(struct device *dev)
> +{
> + struct platform_device *pdev = to_platform_device(dev);
> + struct imx_port *sport = platform_get_drvdata(pdev);
> + int ret;
> +
> + ret = clk_enable(sport->clk_ipg);
> + if (ret)
> + dev_err(dev, "UART%d resume error!\r\n", sport->port.line);
Same here.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
