Re: [PATCH V2] tty: serial: imx.c: Reset UART before activating interrupts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Fabio,

On Wed, 29 Jul 2015 13:24:07 -0300
Fabio Estevam <festevam@xxxxxxxxx> wrote:

> Hi David,
> 
> On Wed, Jul 29, 2015 at 1:00 PM, David Jander <david@xxxxxxxxxxx> wrote:
> > If the UART has been in use before this driver was loaded, IRQs might be
> > active and get fired as soon as we set the handler, which will crash
> > in the spin_lock_irqsave(&sport->port.lock, flags) because port.lock is
> > not initialized until the port is added at the end of probe.
> >
> > Signed-off-by: David Jander <david@xxxxxxxxxxx>
> 
> Now I have a good console output, thanks!

Thanks for testing.
Just to be sure, from reading Chapter 63.3.2.1 of the i.MX6Q reference manual,
I understand that peripheral clock is needed for accessing registers, while ipg
clock ("module clock") is used for shift registers and state-machine. AFAICS,
enabling peripheral clock should be enough for resetting the UART. Do you agree
with this?

Best regards,

-- 
David Jander
Protonic Holland.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux