Hi David,
On 07/28/2015 02:07 AM, David Jander wrote:
> On Mon, 27 Jul 2015 15:15:59 -0300
> Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> wrote:
>
>> This reverts commit e95044ba4fee93f5ea8a1a24b2d921e148503833.
>>
>> Commit e95044ba4fee93 ("tty: serial: imx.c: Reset UART before activating
>> interrupts") terribly messes up with the console on mx6 boards, so
>> let's revert it.
>
> IMHO Spewing out a few corrupt characters during startup (which curiously also
> appear sometimes due to other reasons), is a lot less of a problem that a
> hanging system!
Seems you already know the symptoms. Was the console corruption a known issue
before submitting? I didn't see anything in the changelog or discussion at
submission time?
> Please don't revert this patch without providing a fix for the crash!
This clearly isn't the correct fix, and it makes no sense to build a proper
fix on top of a broken one.
The right way is to revert this and try again.
This time I would look at moving the request_irq() into the startup() method
like every other serial driver does.
Regards,
Peter Hurley
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
