On Wed, May 20, 2015 at 8:21 PM, Jon Hunter <jonathanh@xxxxxxxxxx> wrote: > If the call to dmaengine_slave_config() fails, then the DMA buffer will > not be freed/unmapped. Fix this by moving the code that stores the > address of the buffer in the tegra_uart_port structure to before the > call to dmaengine_slave_config(). > > Reported-by: Alexandre Courbot <acourbot@xxxxxxxxxx> > Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx> Looks good, we had the same if/else condition appearing three times in this function for no real reason anyway. This considerably simplifies the code. > drivers/tty/serial/serial-tegra.c | 32 +++++++++++--------------------- > 1 file changed, 11 insertions(+), 21 deletions(-) Negative number of lines, another good point for this patch! Reviewed-by: Alexandre Courbot <acourbot@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
