Hello, On Tue, May 19, 2015 at 03:49:14PM +0200, Janusz Użycki wrote: > >@@ -118,7 +117,7 @@ void mctrl_gpio_free(struct device *dev, struct mctrl_gpios *gpios) > > enum mctrl_gpio_idx i; > > for (i = 0; i < UART_GPIO_MAX; i++) > >- if (!IS_ERR_OR_NULL(gpios->gpio[i])) > >+ if (!gpios->gpio[i]) > > Isn't inverted here? You're right. Good catch. Unfortunately I don't have hardware to test this, so it was only compile tested. Will send a v2. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html