Hi Russell, On 05/06/2015 06:34 AM, Russell King - ARM Linux wrote: > I've no idea why you've gone to using constants in the array initialisation > either. If you're going to do that, then please use the enum approach > right from the start, or go back to what you were doing. This patch version (v6) is stale. The most recent version for your review is v9, dated May 4. That version uses the enum style. Regards, Peter Hurley -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html