On Thu, Apr 30, 2015 at 08:21:03AM -0300, Albino Biasutti Neto wrote:
> 2015-04-30 6:22 GMT-03:00 Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>:
> > +++ b/drivers/tty/hvc/hvcs.c
> > @@ -1044,8 +1044,8 @@ static int hvcs_enable_device(struct hvcs_struct *hvcsd, uint32_t unit_address,
> > * It is possible that the vty-server was removed between the time that
> > * the conn was registered and now.
> > */
> > - if (!(rc = request_irq(irq, &hvcs_handle_interrupt,
> > - 0, "ibmhvcs", hvcsd))) {
> > + rc = request_irq(irq, &hvcs_handle_interrupt, 0, "ibmhvcs", hvcsd);
>
> Good.
>
> > + if (!rc) {
> > /*
> > * It is possible the vty-server was removed after the irq was
> > * requested but before we have time to enable interrupts.
>
> Remove line ?
What do you mean by this? The code logic isn't changing here. If the
comment isn't correct anymore, that should be a separate patch
explaining why that is the case.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
