On Friday 24 April 2015 13:48:57 Joachim Eastwood wrote: > Hi, > > I am working on a DT supported SoC which has a 8250-based USART block > with some additional features: > - Two clocks (baud and reg) > - DMA support (DMA engine) > - RS485 > > Should support for these things be put into a 8250_<soc uart>.c file > or should of_serial.c be extended? > I am leaning towards creating a 8250_<soc uart>.c since the RS485 > support can't be made generic here. Yes, that seems fine. If you need a separate file, don't put it into of_serial.c > On a related note: How should quirks be handeled? > Example: arch/arm/mach-lpc32xx/serial.c does applies a lot of errata > workarounds. (This UART also requires two clocks) > Should this be moved into a 8250_lpc32xx_uart.c file or it's there a > better place to do this? That code probably needs to be rewritten before it can be put into drivers/tty/serial/, but I think that's where it should go if anyone finds the time, and can convert lpc32xx to use common-clk first. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
