On Tue, Mar 31, 2015 at 09:11:40PM +0200, moorray3@xxxxx wrote: > From: Jakub Kicinski <kubakici@xxxxx> > > Hardware is capable of inverting RTS signal when working > in RS-485 mode. Expose this functionality to user space. > Relay on a matching combination of standard flags > (SER_RS485_RTS_ON_SEND and SER_RS485_RTS_AFTER_SEND) to > detect when user space is requesting inverted RTS mode. > > Signed-off-by: Jakub Kicinski <kubakici@xxxxx> > --- > Thank you for prompt review. I changed to dev_err and made the message > more explicit. I also added the current flag setting to the message to > make it more obvious which parameters influence the error. Are these > changes steps in a right direction? Looks good to me, thanks for the changes. I'll let others verify it as well. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
