On Fri, Mar 13, 2015 at 04:48:50PM +0000, Andrew Jackson wrote:
> > +static int zx_uart_remove(struct platform_device *pdev)
> > +{
> > + struct uart_amba_port *uap = platform_get_drvdata(pdev);
> > + int i;
> > +
> > + uart_remove_one_port(&amba_reg, &uap->port);
> > +
> > + for (i = 0; i < ARRAY_SIZE(amba_ports); i++)
> > + if (amba_ports[i] == uap)
> > + amba_ports[i] = NULL;
> > +
> > + pl011_dma_remove(uap);
> > + return 0;
> > +}
>
> Since the references to zx_uart_probe and zx_uart_remove are conditionally compiled,
> you should also so bracket them here to avoid complaints about unused functions.
Right, the comment applies to pl011_probe and pl011_remove as well.
Compiling the driver for zx_uart, I got the following warnings.
CC drivers/tty/serial/amba-pl011.o
../drivers/tty/serial/amba-pl011.c:2259:12: warning: ‘pl011_probe’ defined but not used [-Wunused-function]
../drivers/tty/serial/amba-pl011.c:2345:12: warning: ‘pl011_remove’ defined but not used [-Wunused-function]
../drivers/tty/serial/amba-pl011.c:2490:23: warning: ‘pl011_ids’ defined but not used [-Wunused-variable]
Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
