RE: [PATCH 2/2] serial: fsl_lpuart: Remove unneeded registration message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>-----Original Message-----
>From: Fabio Estevam [mailto:festevam@xxxxxxxxx]
>Sent: Friday, November 07, 2014 10:23 AM
>To: gregkh@xxxxxxxxxxxxxxxxxxx
>Cc: Lu Jingchang-B35083; linux-serial@xxxxxxxxxxxxxxx; Estevam Fabio-
>R49496
>Subject: [PATCH 2/2] serial: fsl_lpuart: Remove unneeded registration
>message
>
>From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
>
>There is no real value in displaying "serial: Freescale lpuart driver" in
>every boot.
>
>The uart_register_driver() can fail and even so the "serial: Freescale
>lpuart driver" will be displayed, which is not really helpful.
>
>This is particularly annoying when booting multi_v7_defconfig kernel on a
>SoC that is not a Vybrid/Layerscape and even though this message gets
>displayed.
>
>Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>

Acked-by: Jingchang Lu <jingchang.lu@xxxxxxxxxxxxx>

>---
> drivers/tty/serial/fsl_lpuart.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/drivers/tty/serial/fsl_lpuart.c
>b/drivers/tty/serial/fsl_lpuart.c index 567d0ad..08c8651 100644
>--- a/drivers/tty/serial/fsl_lpuart.c
>+++ b/drivers/tty/serial/fsl_lpuart.c
>@@ -1882,11 +1882,8 @@ static struct platform_driver lpuart_driver = {
>
> static int __init lpuart_serial_init(void)  {
>-	int ret;
>-
>-	pr_info("serial: Freescale lpuart driver\n");
>+	int ret = uart_register_driver(&lpuart_reg);
>
>-	ret = uart_register_driver(&lpuart_reg);
> 	if (ret)
> 		return ret;
>
>--
>1.9.1

��.n��������+%������w��{.n�����{��ǫ����{ay�ʇڙ���f���h������_�(�階�ݢj"��������G����?���&��





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux