Hi Lars,
On Tue, 2014-11-04 at 11:49AM +0100, Lars-Peter Clausen wrote:
> Add support for setting the state of the DTR and RTS signals.
>
> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
> ---
> drivers/tty/serial/xilinx_uartps.c | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> index 200c1af..fb1de12 100644
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -133,6 +133,15 @@ MODULE_PARM_DESC(rx_timeout, "Rx timeout, 1-255");
> #define CDNS_UART_IXR_BRK 0x80000000
>
> /*
> + * Modem Control register:
> + * The read/write Modem Control register controls the interface with the modem
> + * or data set, or a peripheral device emulating a modem.
> + */
> +#define CDNS_UART_MODEMCR_FCM 0x00000020 /* Automatic flow control mode */
> +#define CDNS_UART_MODEMCR_RTS 0x00000002 /* Request to send output control */
> +#define CDNS_UART_MODEMCR_DTR 0x00000001 /* Data Terminal Ready */
I'd prefer using the BIT() macro, but I see that it doesn't really fit
the style of other #defines in the driver. So, probably ok this way.
> +
> +/*
> * Channel Status Register:
> * The channel status register (CSR) is provided to enable the control logic
> * to monitor the status of bits in the channel interrupt status register,
> @@ -915,7 +924,18 @@ static unsigned int cdns_uart_get_mctrl(struct uart_port *port)
>
> static void cdns_uart_set_mctrl(struct uart_port *port, unsigned int mctrl)
> {
> - /* N/A */
> + unsigned int val;
This should be u32.
I don't have a setup to actually test this, but it applies and doesn't
seem to break anything :)
Given that you fix the data type:
Acked-by: Soren Brinkmann <soren.brinkmann@xxxxxxxxxx>
Thanks,
Sören
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
