Hi Greg, This patch series: 1. removes stale code from the controlling tty handling functions 2. relocates the ctty functions to eliminate forward declarations 3. fixes several unsafe races when setting the controlling tty 4. eliminates holding tty_mutex as a necessary condition of setting the controlling terminal #4 is part of an overall effort to reduce the tty_mutex footprint. Unfortunately, this series does not fix two other race conditions: 1. disassociate_ctty()/no_tty() does not teardown the tty<->process associations atomically wrt job control, so it is possible to observe spurious error conditions from job control (tty_check_change() and job_control()). I'm looking into inverting the lock order of tty->ctrl_lock and tsk->sighand->siglock() to see if holding ctrl_lock is a suitable solution for atomic teardown. Especially now that ctrl_lock is not used for flow control anymore :) 2. task_pgrp() and task_session() are used unsafely. These fixes will be clearer after #1 is fixed. Regards, Peter Hurley (10): tty: Remove tty_pair_get_tty()/tty_pair_get_pty() api tty: Reorder proc_set_tty() and related fns tty: Remove tsk parameter from proc_set_tty() uml: Fix unsafe pid reference to foreground process group tty: Replace open-coded tty_get_pgrp() tty: Remove !tty condition from __proc_set_tty() tty: Fix multiple races when setting the controlling terminal tty: Move session_of_pgrp() and make static tty: Serialize proc_set_tty() with tty_lock tty: Update code comment in __proc_set_tty() arch/um/drivers/line.c | 6 +- drivers/tty/pty.c | 24 ++---- drivers/tty/tty_io.c | 204 +++++++++++++++++++++++++++---------------------- include/linux/kernel.h | 3 - include/linux/tty.h | 3 - kernel/exit.c | 21 ----- 6 files changed, 123 insertions(+), 138 deletions(-) -- 2.1.1 -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
