>-----Original Message----- >From: Joseph Lo [mailto:josephl@xxxxxxxxxx] >Sent: Wednesday, October 15, 2014 2:53 PM >To: Lu Jingchang-B35083; gregkh@xxxxxxxxxxxxxxxxxxx >Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-serial@xxxxxxxxxxxxxxx; >peter@xxxxxxxxxxxxxxxxxx; arnd@xxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx >Subject: Re: [PATCHv4] serial: of-serial: fix up PM ops on >no_console_suspend and port type > >On 10/15/2014 02:41 PM, Joseph Lo wrote: >> On 10/15/2014 02:32 PM, Jingchang Lu wrote: >>>> -----Original Message----- >>>> From: Joseph Lo [mailto:josephl@xxxxxxxxxx] >>>> Sent: Wednesday, October 15, 2014 9:01 AM >>>> To: Lu Jingchang-B35083; gregkh@xxxxxxxxxxxxxxxxxxx >>>> Cc: peter@xxxxxxxxxxxxxxxxxx; arnd@xxxxxxxx; >>>> linux-kernel@xxxxxxxxxxxxxxx; linux-serial@xxxxxxxxxxxxxxx; >>>> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx >>>> Subject: Re: [PATCHv4] serial: of-serial: fix up PM ops on >>>> no_console_suspend and port type >>>> >>>> On 10/14/2014 04:42 PM, Jingchang Lu wrote: >>>>> This patch fixes commit 2dea53bf57783f243c892e99c10c6921e956aa7e, >>>>> "serial: of-serial: add PM suspend/resume support", which disables >>>>> the uart clock on suspend, but also causes a hardware hang on >>>>> register access if no_console_suspend command line option is used. >>>>> >>>>> Also, not every of_serial device is an 8250 port, so the serial8250 >>>>> suspend/resume functions should only be applied to a real 8250 port. >>>>> >>>>> Signed-off-by: Jingchang Lu <jingchang.lu@xxxxxxxxxxxxx> >>>> >>>> If you can make sure this patch can build without include >>>> <linux/console.h>, then this patch >>> The build passes on my cloned linux-next tree, include next-20141014, >>> but is required on my another kernel-3.12+ based tree, then I didn't >>> add this header file when upstream. >>> Is the build broken on your source tree, and is the tree latest? >>> If the header is needed, I will add it. >> I tested it on next-20141013 and k3.14, both of them need the fix. I >> can check it again against the latest linux-next tree later. Thanks. >> >OK, I confirmed it. You should add the header file. It also doesn't build >for me with the latest linux-next tree. Maybe you missed to enable >CONFIG_PM_SLEEP or CONFIG_SERIAL_8250 when doing the build test in linux- >next tree. I have sent out the v5 patch with last git-send-email command line, didn't realized the missing of your email address in the cc list when sending. Please help review the v5 patch. Thanks. Best Regards, Jingchang > >-Joseph ��.n��������+%������w��{.n�����{��ǫ����{ay� ʇڙ���f���h������_�(�階�ݢj"��������G����?���&��
