On 08/20/2014 11:39 AM, Frans Klaver wrote:
>>> static int serial8250_get_poll_char(struct uart_port *port)
>>> {
>>> - unsigned char lsr = serial_port_in(port, UART_LSR);
>>> + unsigned char lsr;
>>> + int status;
>>> +
>>> + serial8250_rpm_get(up);
>>
>> or up won't be defined below. You probably need
>
> Obviously I meant to say that 'up' won't be defined here.
Good catch, thanks. However I wouldn't bet my money it that won't be
defined here. The semaphore code provides up() and down() so it is
makes it kind of defined :) But it doesn't compile due to wrong pointer
types which is good (I run into this myself and looked confused at
first).
I didn't notice this at all because only kgdb uses this
CONFIG_CONSOLE_POLL which I had off. Once again, thank you.
>> + struct uart_8250_port *up = up_to_u8250p(port);
>> somewhere in there.
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
