Re: [PATCH] serial: 8250_hp300: trivial: fix symbol name in #warning message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 08, 2014 at 05:14:32PM +0200, Daniele Forsi wrote:
> The symbol is defined in drivers/tty/serial/8250/Kconfig as
> "SERIAL_8250", not just "8250".
> 
> Signed-off-by: Daniele Forsi <dforsi@xxxxxxxxx>
> ---
>  drivers/tty/serial/8250/8250_hp300.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/tty/serial/8250/8250_hp300.c b/drivers/tty/serial/8250/8250_hp300.c
> index 5bdaf27..f155328 100644
> --- a/drivers/tty/serial/8250/8250_hp300.c
> +++ b/drivers/tty/serial/8250/8250_hp300.c
> @@ -24,6 +24,10 @@
>  #warning CONFIG_8250 defined but neither CONFIG_HPDCA nor CONFIG_HPAPCI defined, are you sure?
>  #endif
>  
> +#if !defined(CONFIG_HPDCA) && !defined(CONFIG_HPAPCI)
> +#warning CONFIG_SERIAL_8250 defined but neither CONFIG_HPDCA nor CONFIG_HPAPCI defined, are you sure?
> +#endif

Shouldn't you just change the line before this one with the proper
config option?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux