Hello Alan > Is there any reasons we can't have uart_ops.rs485_config and the RS485 > ioctl logic in the serial_core, or even push rs485_get/put into the tty > ioctl handler and tty ops so it's not duplicated everywhere ? What about a step by step approach. First we add this code to the 8250_core, and then I remove all the specific driver TIOCSRS485 handling and manage it through serial_core.c Right now these are the drivers using it: drivers/tty/serial/8250/8250_core.c: case TIOCSRS485: drivers/tty/serial/atmel_serial.c: case TIOCSRS485: drivers/tty/serial/crisv10.c: case TIOCSRS485: drivers/tty/serial/max310x.c: case TIOCSRS485: drivers/tty/serial/mcf.c: case TIOCSRS485: { drivers/tty/serial/omap-serial.c: case TIOCSRS485: rivers/tty/serial/sc16is7xx.c: case TIOCSRS485: Regards! -- Ricardo Ribalda -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html