Hello Jon Ringle,
The patch dfeae619d781: "serial: sc16is7xx" from Apr 24, 2014, leads
to the following static checker warning:
drivers/tty/serial/sc16is7xx.c:1168 sc16is7xx_probe()
warn: 's->clk' isn't an ERR_PTR
drivers/tty/serial/sc16is7xx.c
1167 out_clk:
1168 if (!IS_ERR(s->clk))
^^^^^^^^^^^^^
This check isn't needed because we return directly but also I don't
think we ever set s->clk so it is leaked on the remove() path as well.
1169 clk_disable_unprepare(s->clk);
1170
1171 return ret;
1172 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
