> > +struct dw8250_acpi_desc {
> > + unsigned int uartclk;
> This one we could actually drop while at it. The uartclk was
> originally delivered as driver data in case of ACPI, but we now get a
> clk for ACPI enumerated boards.
Ok!
> > + void (*setup)(struct uart_8250_port *up);
> Why not just have the set_termios hook here?
It was to allow any future other byt specific init
In the setup (no just set_termios). But, yes I can
point directly to set_termios.
> But I don't have a problem if we go ahead with this first. We can
> always change it later. In any case, I'll prepare the clock driver in
> drivers/acpi/acpi_lpss.c for this. Let's see what Rafael and Mika
> think about it.
Sounds good, while waiting to get a better solution, I'm going to
upload a new patch version.
Thanks & Regards,
Loic
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
