On Thu, Mar 20, 2014 at 12:40:40PM -0700, Marcel Holtmann wrote: > Hi Felipe, > > > LDISCs shouldn't call tty->ops->write() from within > > ->write_wakeup(). > > > > ->write_wakeup() is called with port lock taken and > > IRQs disabled, tty->ops->write() will try to acquire > > the same port lock and we will deadlock. > > > > Reviewed-by: Peter Hurley <peter@xxxxxxxxxxxxxxxxxx> > > Reported-by: Huang Shijie <b32955@xxxxxxxxxxxxx> > > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > > --- > > drivers/bluetooth/hci_ldisc.c | 24 +++++++++++++++++++----- > > drivers/bluetooth/hci_uart.h | 1 + > > 2 files changed, 20 insertions(+), 5 deletions(-) > > I hope these are not causing any conflicts with bluetooth-next / > linux-next. If not, then I can let Greg take it through tty-next tree. > > Acked-by: Marcel Holtmann <marcel@xxxxxxxxxxxx> tty-next is already closed, i'll rebase (if necessary) once -rc1 is out ;-) cheers -- balbi
Attachment:
signature.asc
Description: Digital signature
