Re: serial core: crash / race condition on unbind

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/11/2014 11:35 AM, Geert Uytterhoeven wrote:
On Tue, Mar 11, 2014 at 12:49 PM, Peter Hurley <peter@xxxxxxxxxxxxxxxxxx> wrote:
On 03/11/2014 06:58 AM, Geert Uytterhoeven wrote:
On Tue, Mar 11, 2014 at 4:14 AM, Peter Hurley <peter@xxxxxxxxxxxxxxxxxx>
wrote:


           [...]

           /*
            * Indicate that there isn't a port here anymore.
            */
           uport->type = PORT_UNKNOWN;

           state->uart_port = NULL;


How did this ever work?

Detaching the ll driver from the tty port in this manner is not ok;
as you already note, it blows up if consoles are still running.

No one unbinds serial drivers using serial_core, as all these drivers are
for fixed hardware?

Yep, never tested until now :)
Do you need this to work?

Well, "need" may be a bit strong. Crashes are not so nice.

:)

What I meant was, 'is this a debug situation that I can eventually get to?'
or 'are you on the verge of shipping product and this is a priority?'

Regards,
Peter Hurley

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux