Greg, This patchset is a v2 respin which contains no bug fixes, only misc cleanup for the N_TTY line discipline and significant additions to debug tracing. As I mentioned in a previous email, I can hold on to patches 7 and 8 and keep them out-of-tree if you'd rather not have instrumented code in the tty layer. v2: - Patches 1-6 are unchanged from v1. - Patch 7 changes: make n_tty_trace() configurable to output via pr_xxxx() or dev_dbg() rather than trace_printk() per Alan's comments - Patch 8 adds echo buffer indices tracing (separately selectable) v1: Patches 1-4 cleans up code duplication remnants from 3.12's changes. Patch 5 simplifies the snarled logic of how much data is considered 'input available'. I was getting tired of hand checking that logic every time I touched minimum_to_wake. Patch 6 reduces unnecessary wake ups. Patch 7 extends the trace usage to aid in identifying and fixing input flow-control bugs (this was used to fix the readline() bug). I also expect to use it to reduce input processing restarts. It's use is disabled by default and only enabled with the file-local define N_TTY_TRACE (similar to TTY_DEBUG_HANGUP in tty_io.c). Regards, Peter Hurley (8): n_tty: Merge .receive_buf() flavors n_tty: Un-inline slow-path n_tty_receive_char() n_tty: Un-inline slow-path n_tty_receive_char_closing() n_tty: Refactor PARMRK doubling checks n_tty: Refactor input_available_p() by call site n_tty: Only perform wakeups for waiters n_tty: Extend debug tracing n_tty: Trace echo output with separate trace configuration drivers/tty/n_tty.c | 174 +++++++++++++++++++++++++++++++++------------------- 1 file changed, 112 insertions(+), 62 deletions(-) -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
