On Thu, Oct 31, 2013 at 09:09:51AM -0400, Philippe Proulx wrote:
> ----- Original Message -----
> > From: "Sedat Dilek" <sedat.dilek@xxxxxxxxx>
> > To: "Stephen Rothwell" <sfr@xxxxxxxxxxxxxxxx>, "Philippe Proulx" <philippe.proulx@xxxxxxxxxxxxxxxxxxxx>
> > Cc: "Greg KH" <greg@xxxxxxxxx>, "linux-next" <linux-next@xxxxxxxxxxxxxxx>, "LKML" <linux-kernel@xxxxxxxxxxxxxxx>,
> > linux-serial@xxxxxxxxxxxxxxx
> > Sent: Thursday, 31 October, 2013 6:35:23 AM
> > Subject: Re: linux-next: build failure after merge of the tty tree
> >
> > On Thu, Oct 31, 2013 at 8:40 AM, Stephen Rothwell
> > <sfr@xxxxxxxxxxxxxxxx> wrote:
> > > Hi Greg,
> > >
> > > After merging the tty tree, today's linux-next build (arm
> > > multi_v7_defconfig) failed like this:
> > >
> > > drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe':
> > > drivers/tty/serial/omap-serial.c:1724:22: error: expected ')'
> > > before numeric constant
> > > drivers/tty/serial/omap-serial.c:1724:22: warning: format '%d'
> > > expects a matching 'int' argument [-Wformat]
> > >
> > > Caused by commit e5f9bf72efbc ("serial: omap: fix a few checkpatch
> > > warnings"). There is a missing ',' in the dev_warn() ...
> > >
> > > I have used the version of the tty tree from next-20131030 for
> > > today.
> > >
> >
> > [ Add CC to linux-serial ML ]
> >
> > Happy HelloWien and WelcomeBackStephen!
> >
> > That was only checkpatch-tested, eh :-)?
> >
> > @@ -1724,8 +1722,9 @@ static int serial_omap_probe(struct
> > platform_device *pdev)
> > up->port.uartclk = omap_up_info->uartclk;
> > if (!up->port.uartclk) {
> > up->port.uartclk = DEFAULT_CLK_SPEED;
> > - dev_warn(&pdev->dev, "No clock speed specified: using default:"
> > - "%d\n", DEFAULT_CLK_SPEED);
> > + dev_warn(&pdev->dev,
> > + "No clock speed specified: using default: %d\n" <--- Comma missing
> > here!
>
> Oops, something obviously went wrong in my process. Sorry about this.
>
> Do you want me to fix this commit?
Please send me a patch that I can apply.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
