Re: [PATCH 4/5] serial: pch_uart: remove reference to .set_wake()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2013-10-15 at 09:20 +0200, Linus Walleij wrote:
> This callback is gone and not coming back, so will not be
> supported later.
> 
> Cc: Johan Hovold <jhovold@xxxxxxxxx>
> Cc: Darren Hart <dvhart@xxxxxxxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Thanks Linus,

No objection here, however...


> ---
>  drivers/tty/serial/pch_uart.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c
> index 44077c0..10472b7 100644
> --- a/drivers/tty/serial/pch_uart.c
> +++ b/drivers/tty/serial/pch_uart.c
> @@ -1614,7 +1614,6 @@ static struct uart_ops pch_uart_ops = {
>  	.shutdown = pch_uart_shutdown,
>  	.set_termios = pch_uart_set_termios,
>  /*	.pm		= pch_uart_pm,		Not supported yet */
> -/*	.set_wake	= pch_uart_set_wake,	Not supported yet */

>From what I can tell with "git log -S", this callback never existed for
this driver. I am curious what prompted the removal of this comment
(since the set_wake field still exists in the structure) and .pm was
left alone, which seems to have the same history within this driver
as .set_wake.

>  	.type = pch_uart_type,
>  	.release_port = pch_uart_release_port,
>  	.request_port = pch_uart_request_port,

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel


--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux