Re: [PATCH 02/15] serial: ar933x: remove unnecessary platform_set_drvdata()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, May 07, 2013 4:59 PM, Jingoo Han wrote:
> 
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
> 
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>

Hi Greg,

I will squash everything down into one patch with the ACKs,
and send it again.

Best regards,
Jingoo Han

> ---
>  drivers/tty/serial/ar933x_uart.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/tty/serial/ar933x_uart.c b/drivers/tty/serial/ar933x_uart.c
> index 27f20c5..9824dfb 100644
> --- a/drivers/tty/serial/ar933x_uart.c
> +++ b/drivers/tty/serial/ar933x_uart.c
> @@ -703,7 +703,6 @@ static int ar933x_uart_remove(struct platform_device *pdev)
>  	struct ar933x_uart_port *up;
> 
>  	up = platform_get_drvdata(pdev);
> -	platform_set_drvdata(pdev, NULL);
> 
>  	if (up) {
>  		uart_remove_one_port(&ar933x_uart_driver, &up->port);
> --
> 1.7.2.5


--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux