2013/5/7 Jingoo Han <jg1.han@xxxxxxxxxxx>
>
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
Acked-by: Barry Song <baohua.song@xxxxxxx>
> ---
> drivers/tty/serial/sirfsoc_uart.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/sirfsoc_uart.c
> b/drivers/tty/serial/sirfsoc_uart.c
> index 03465b6..f256440 100644
> --- a/drivers/tty/serial/sirfsoc_uart.c
> +++ b/drivers/tty/serial/sirfsoc_uart.c
> @@ -716,7 +716,6 @@ port_err:
> clk_disable_unprepare(sirfport->clk);
> clk_put(sirfport->clk);
> clk_err:
> - platform_set_drvdata(pdev, NULL);
> if (sirfport->hw_flow_ctrl)
> pinctrl_put(sirfport->p);
> err:
> @@ -727,7 +726,7 @@ static int sirfsoc_uart_remove(struct platform_device
> *pdev)
> {
> struct sirfsoc_uart_port *sirfport = platform_get_drvdata(pdev);
> struct uart_port *port = &sirfport->port;
> - platform_set_drvdata(pdev, NULL);
> +
> if (sirfport->hw_flow_ctrl)
> pinctrl_put(sirfport->p);
> clk_disable_unprepare(sirfport->clk);
> --
> 1.7.2.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
