This 3rd of 4 patchsets implements a mostly-lockless tty echo output. Because echoing is performed solely by the single-threaded ldisc receive_buf() method, most of the lockless requirements are already in-place. The main existing complications were; 1) Echoing could overrun itself. A fixed-size buffer is used to record the operations necessary when outputting the echoes; the most recent echo data is preserved. 2) An attempt to push unprocessed echoes is made by the n_tty_write method (on a different thread) before attempting write output. The overrun condition is solved by outputting the echoes in blocks and ensuring that at least that much space is available each time an echo operation is committed. At the conclusion of each flip buffer received, any remaining unprocessed echoes are output. This block output method is particularly effective when there is no reader (the tty is output-only) and termios is misconfigured with echo enabled. The concurrent access by the n_tty_write() method is already excluded by the existing output_lock mutex. Peter Hurley (9): n_tty: Remove unused echo_overrun field n_tty: Use separate head and tail indices for echo_buf n_tty: Replace echo_cnt with computed value n_tty: Remove echo_lock n_tty: Eliminate echo_commit memory barrier n_tty: Process echoes in blocks n_tty: Only flush echo output if actually output n_tty: Eliminate counter in __process_echoes n_tty: Avoid false-sharing echo buffer indices drivers/tty/n_tty.c | 248 ++++++++++++++++++++++++---------------------------- 1 file changed, 113 insertions(+), 135 deletions(-) -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
