Hi, I need to redo this patch. On Wed, Apr 10, 2013 at 04:58:32PM +0300, Heikki Krogerus wrote: > Use resource managed ioremap. > > Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > --- > drivers/tty/serial/8250/8250_dw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c > index b7c7d6a..bf2a6e2 100644 > --- a/drivers/tty/serial/8250/8250_dw.c > +++ b/drivers/tty/serial/8250/8250_dw.c > @@ -250,7 +250,7 @@ static int dw8250_probe(struct platform_device *pdev) > uart.port.flags = UPF_SHARE_IRQ | UPF_BOOT_AUTOCONF | UPF_FIXED_PORT; > uart.port.dev = &pdev->dev; > > - uart.port.membase = ioremap(regs->start, resource_size(regs)); > + uart.port.membase = devm_request_and_ioremap(&pdev->dev, regs); There is now function devm_ioremap_resource() that should be preferred over devm_request_and_ioremap(), but I will change this to use devm_ioremap(). There is no need to request the mem region here. -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html