> > Hi, > > > > > > > + return snprintf(buf, PAGE_SIZE, "uart\n"); > > > > > > > > What is the "uart" part for? Isn't that kind of obvious? > > > > > > It is the default "peripheral_type" content. > > > Before sending next revision out, let me ask a question here: > > > Shall I leave this empty as my previous revisions? > > > > Hmm, if this is empty by default then the udev rules may require additional > handlings. > > Can I use "NONE" here for the user space users? > > No, just don't create the sysfs file at all for that type of device. Sorry for the delayed reply. I was thinking developers are encouraged to use the default attributes. In the tty subsystem, the default attributes are owned by the tty drivers, thus I added peripheral_type file in the serial layer. If we want to have it as a dynamic attribute, we may modify the codes in the tty_register_device_attr, splitting device_register into two parts, and add sysfs addition codes between the device_initialize and device_add. So that the uevents received by the user space can have this attribute set. Sorry that I need your confirmation before doing such modification. Thanks and best regards -Lv -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
