On Fri, Mar 15, 2013 at 8:30 PM, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Mon, Mar 04, 2013 at 09:35:07AM +0800, Grant Likely wrote: >> drivers/tty/serial/8250/8250.c: In function 'serial_unlink_irq_chain': >> drivers/tty/serial/8250/8250.c:1676:19: warning: 'i' may be used uninitialized in this function >> >> There isn't an actual bug here since the function tests the condition >> that would cause i to be uninitialized before dereferencing i. However, >> at least some versions of GCC complain as shown above. (in my case, >> powerpc gcc 2.5.2). Initializing i to NULL makes it clear to GCC and the >> casual code reviewer that i will not be dereferenced to a random >> address. >> >> Signed-off-by: Grant Likely <grant.likely@xxxxxxxxxxxx> >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> --- >> Greg, some may argue that this is a tool problem, not a kernel problem, >> but it is useful to me. If anyone objects I'm not going to spend any >> time championing for this patch. > > Upgrade your tools to ones that work properly :) FWIW, it's still a toolchain that a lot of people use for embedded powerpc development. g. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
