On Mon, 2013-03-04 at 14:24 +0530, Sachin Kamat wrote:
> Use the newly introduced devm_ioremap_resource() instead of
> devm_request_and_ioremap() which provides more consistent error handling.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
> ---
> drivers/tty/serial/vt8500_serial.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/vt8500_serial.c b/drivers/tty/serial/vt8500_serial.c
> index a3f9dd5..f15f53f 100644
> --- a/drivers/tty/serial/vt8500_serial.c
> +++ b/drivers/tty/serial/vt8500_serial.c
> @@ -35,6 +35,7 @@
> #include <linux/clk.h>
> #include <linux/platform_device.h>
> #include <linux/of.h>
> +#include <linux/err.h>
>
> /*
> * UART Register offsets
> @@ -585,9 +586,9 @@ static int vt8500_serial_probe(struct platform_device *pdev)
> if (!vt8500_port)
> return -ENOMEM;
>
> - vt8500_port->uart.membase = devm_request_and_ioremap(&pdev->dev, mmres);
> - if (!vt8500_port->uart.membase)
> - return -EADDRNOTAVAIL;
> + vt8500_port->uart.membase = devm_ioremap_resource(&pdev->dev, mmres);
> + if (IS_ERR(vt8500_port->uart.membase))
> + return PTR_ERR(vt8500_port->uart.membase);
>
> vt8500_port->clk = of_clk_get(pdev->dev.of_node, 0);
> if (IS_ERR(vt8500_port->clk)) {
Acked-by: Tony Prisk <linux@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
