Hi Simon! 2013/3/4 Magnus Damm <magnus.damm@xxxxxxxxx>: > Hi Simon, > > [Added Guennadi to CC] > > On Sat, Mar 2, 2013 at 10:31 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote: >> On Fri, Mar 01, 2013 at 10:21:27AM -0600, Bastian Hecht wrote: >>> 2013/3/1 Simon Horman <horms@xxxxxxxxxxxx>: >>> > On Tue, Feb 26, 2013 at 11:03:28AM -0600, Bastian Hecht wrote: >>> >> We can now use the Device Tree for bringing up our serial devices. We >>> >> need to add an alternative early_devices list in setup-r8a7740 without >>> >> the serial devices and move them into the Armadillo-reference .dts config file. >>> > >>> > Hi Bastian, >>> > >>> > could you please refresh this patch on top of the current topic/intc-of. >>> > In particular, it conflicts with changes made by: >>> > >>> > ARM: shmobile: r8a7740: Do not use early devices with DT reference >>> >>> Sure. >>> >>> I've prepared the patch - but I start to wonder if the DT >>> specification for the SCIF devices should go into r8a7740.dtsi rather >>> than r8a7740-armadillo-reference.dts. So far it's included in >>> setup-r8a7740.c and not in the board code - that's a strong indication >>> for it, no? >> >> I forget exactly how the discussion went, but for the kzm9g the >> SDHI has ended up in the dts file for the board not the sh73a0 SoC. >> >> So I assume that r8a7740-armadillo-reference.dts is the correct place >> for SDHI on the armadillo. >> >> Magnus, can you confirm that SDHI belongs to the board not the SoC? > > What does the data sheet say? > > The SDHI hardware block is included in the SoC. It may however need > some board specific configuration. I believe the correct way is to > define the common parts in the SoC-specific dtsi file and add > board-specific configuration in the board-specific dts file. Perhaps > you can consult Guennadi about this, he has been tasked with SDHI and > MMCIF. > >>> I want to post a patchset for the CMT timer soon. There it's the same. >> >> Magnus, could you also let us know if CMT should go in the board or SoC dts? > > In the SoC. As a general rule, if there is a platform device in > setup-nnnn.c then the device does not need any board specific > configuration. Such devices should be put in the SoC-specific dtsi > file. Ok I posted a v4 SCIF DT patchset putting the SCIF devices into r8a7740.dtsi. Simon, are you aware about this in topic/intc-of? It shows up booting the non-DT version. Unable to handle kernel NULL pointer dereference at virtual address 00000040 pgd = c0004000 [00000040] *pgd=00000000 Internal error: Oops: 5 [#1] ARM CPU: 0 Not tainted (3.8.0-rc3-00205-gfb2696a #298) PC is at __gpio_get_value+0x18/0x5c LR is at eva_init+0x190/0x544 We should add standard bootargs in the r8a7740-armadillo800eva.dts as well. Shall I post a small patch? Thanks, Bastian > Thanks, > > / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
