Hi Heikki, On Mon, Dec 03, 2012 at 01:17:57PM +0200, Heikki Krogerus wrote: > This needs to be done in order to later access the > Designware specific registers. > > Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > --- > drivers/tty/serial/8250/8250_dw.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c > index ff83ea5..300bbed 100644 > --- a/drivers/tty/serial/8250/8250_dw.c > +++ b/drivers/tty/serial/8250/8250_dw.c > @@ -111,10 +111,13 @@ static int dw8250_probe(struct platform_device *pdev) > uart.port.irq = irq->start; > uart.port.handle_irq = dw8250_handle_irq; > uart.port.type = PORT_8250; > - uart.port.flags = UPF_SHARE_IRQ | UPF_BOOT_AUTOCONF | UPF_IOREMAP | > - UPF_FIXED_PORT; > + uart.port.flags = UPF_SHARE_IRQ | UPF_BOOT_AUTOCONF | UPF_FIXED_PORT; > uart.port.dev = &pdev->dev; > > + uart.port.membase = ioremap(regs->start, regs->end - regs->start); Doesn't this have an off-by-one error? Perhaps: + uart.port.membase = ioremap(regs->start, resource_size(regs)); instead? Jamie -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
