On Sun, 2 Dec 2012 10:11:58 -0600 Paul Fulghum <paulkf@xxxxxxxxxxxxx> wrote: > True, in this mode line disciplines other than N_HDLC would not be functional and N_HDLC ignores the flag buffer. > This change won’t make other line disciplines useful, it will just prevent the case of a mistakenly selected line discipline accessing beyond the end of the (dummy) flag buffer. > > I’m fine with or without the change. It is functional now with a chance to read past then end of a buffer if misconfigured. With the change, it has the same functionality without the ability to read past the end of a buffer if misconfigured. With the change its feeding crap in the flags buffer, which may matter in future depending what happens to the other bits. If this is a real issue far better to just kzalloc a blank flag buffer to match the mtu. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
