Hi Russell, I made a similar patch a while ago. One note below. (http://marc.info/?l=linux-arm-kernel&m=133372829203680) On 21 September 2012 11:36, Russell King <rmk+kernel@xxxxxxxxxxxxxxxx> wrote: > The definitions provided by serial_at91.h are only used by the > atmel_serial driver, and the function that uses it is never called > from anywhere in the kernel. Therefore, these definitions are unused > and/or obsolete, and can be removed. > > Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx> > --- > arch/arm/include/asm/mach/serial_at91.h | 33 ----------------------------- > arch/avr32/include/asm/mach/serial_at91.h | 33 ----------------------------- > drivers/tty/serial/atmel_serial.c | 18 --------------- > 3 files changed, 0 insertions(+), 84 deletions(-) > delete mode 100644 arch/arm/include/asm/mach/serial_at91.h > delete mode 100644 arch/avr32/include/asm/mach/serial_at91.h <snip> > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c > index 3d7e1ee..a6134c9 100644 > --- a/drivers/tty/serial/atmel_serial.c > +++ b/drivers/tty/serial/atmel_serial.c > @@ -43,7 +43,6 @@ > #include <asm/io.h> > #include <asm/ioctls.h> > > -#include <asm/mach/serial_at91.h> > #include <mach/board.h> > > #ifdef CONFIG_ARM > @@ -1513,23 +1512,6 @@ static void __devinit atmel_init_port(struct atmel_uart_port *atmel_port, > } > } > > -/* > - * Register board-specific modem-control line handlers. > - */ > -void __init atmel_register_uart_fns(struct atmel_port_fns *fns) > -{ > - if (fns->enable_ms) > - atmel_pops.enable_ms = fns->enable_ms; > - if (fns->get_mctrl) > - atmel_pops.get_mctrl = fns->get_mctrl; > - if (fns->set_mctrl) > - atmel_pops.set_mctrl = fns->set_mctrl; > - atmel_open_hook = fns->open; > - atmel_close_hook = fns->close; > - atmel_pops.pm = fns->pm; > - atmel_pops.set_wake = fns->set_wake; > -} When the atmel_open_hook/atmel_open_close assignment is dropped, these global variables will be useless so we should remove them as well. There are also some other code that uses the variables that can be dropped. Should shave another 22 lines of code off atmel_serial.c I can send out a patch on top of yours if you prefer that. regards Joachim Eastwood -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
