-----Original Message----- From: Greg Kroah-Hartman [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] Sent: Friday, November 16, 2012 10:06 AM To: Wu, Fengguang Cc: Chen, Jun D; linux-serial@xxxxxxxxxxxxxxx Subject: Re: [tty:tty-next 76/76] drivers/tty/serial/ifx6x60.c:516:2: warning: ISO C90 forbids mixed declarations and code On Fri, Nov 16, 2012 at 09:09:24AM +0800, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-next > head: e8823f1ca8d5a0c5d69a8862682ee8bde26990ca > commit: e8823f1ca8d5a0c5d69a8862682ee8bde26990ca [76/76] serial: ifx6x60: ifx_spi_write don't need to do mrdy_assert when fifo is not empty > config: i386-randconfig-b691 (attached as .config) > > All warnings: > > drivers/tty/serial/ifx6x60.c: In function 'ifx_spi_write': > drivers/tty/serial/ifx6x60.c:516:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] Ah, missed that one. Jun, care to send a fix for this? [Jun] I have already sent the new patch to fix this warning. > drivers/tty/serial/ifx6x60.c: In function 'ifx_spi_complete': > drivers/tty/serial/ifx6x60.c:726:8: warning: 'more' may be used uninitialized in this function [-Wmaybe-uninitialized] And verify that this isn't a real problem please. [Jun] I didn't modify this line, but I also checked it and can't find warning for " more ". thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
