> + /* Fixme: needs tidying up */ > + check = serial_in(up, UART_EXAR_DVID); > + if ((check == 0x82) || (check == 0x84) || (check == 0x88)) > + p->handle_irq = exar_handle_irq; Can't you check the port type here rather than re-probing stuff ? Otherwise looks good -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html