> > "clk or clock-frequency not > > defined\n"); > > - return -ENODEV; > > + return PTR_ERR(info->clk); > I think this is wrong. it should return -ENODEV; Returning the clock error at least ensures the real reason for the fail is reported. I think its better to use the PTR_ERR but I'd not class either as wrong. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html