From: Vineet Gupta <vgupta@xxxxxxxxxxxx> Hi, Here's the updated revision with all of Felipe' review comments. -Rebased off tty-next tip. -Build tested for x86, both as builtin and as module -Same driver (as module) verified on ARCAngel4 Board. Please consider applying. Thanks, Vineet v7: * Reinstated (request|release)_port() as they are called w/o NULL check by core * verify_port() now does some basic checking * Use container_of() for converting embedded uart_port to arc_uart_port * dev_* instead of pr_* v6: * syntactical changes per comments by Felipe * Empty (request|release)_port removed v5: * Driver now builds as module; default !y * Fixed some build wreckage due to SERIAL_ARC && !SERIAL_ARC_CONSOLE * Fixed a sparse warning due to forced cast, hence reg offsets now in bytes v4: * UAPI disintegration fallout for serial_core.h * rebased off of tty-next v3: * Removed empty arc_serial_set_ldisc() * More set_termios fixes - CSIZE forced to CS8 (for 8N1) * global @running_on_iss replaced with platform data, saved in device specific port structure. v2: * ttyARC used as device name * Dynamic assignment of major/minor numbers. * Ref counting tty in rx routine to prevent it from disappearing in case of a hangup * set_termios fixes: - hardware flow control/parity are marked as unsupported - baud written back to termios * cosmetics such as commenting the need for @running_on_iss, empty lines etc Vineet Gupta (1): serial/arc-uart: Add new driver drivers/tty/serial/Kconfig | 23 ++ drivers/tty/serial/Makefile | 1 + drivers/tty/serial/arc_uart.c | 754 ++++++++++++++++++++++++++++++++++++++ include/uapi/linux/serial_core.h | 2 + 4 files changed, 780 insertions(+), 0 deletions(-) create mode 100644 drivers/tty/serial/arc_uart.c -- 1.7.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html