Re: [PATCH] serial: ifx6x60: add_timer is not safe in the mrdy_assert function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 22 Oct 2012 10:23:07 -0400
Jun Chen <jun.d.chen@xxxxxxxxx> wrote:

> 
> This patch make use of mod_timer instead of add_timer in the mrdy_assert function.
> Because the srdy interrupter can go high when we are running function mrdy_assert and mrdy_assert
> can be called by multi-entry. In our medfield platform, spi stress test can encounter this
> error logs triggered by the BUG_ON of add_timer function.This patch had been tested on
> our medfield platform.
> 
> the scenario:
>       CPU0							CPU1
> mrdy_assert
> set_bit(IFX_SPI_STATE_TIMER_PENDING)
> 								ifx_spi_handle_srdy
> 								...
> 								clear_bit(IFX_SPI_STATE_TIMER_PENDING)
> 								...
> 								mrdy_assert
> 								set_bit(IFX_SPI_STATE_TIMER_PENDING)
> 								...
> 								add_timer
> ...
> add_timer
> 
> cc:liu chuansheng <chuansheng.liu@xxxxxxxxx>
> cc:Bi Chao <chao.bi@xxxxxxxxx>
> Signed-off-by: Chen Jun <jun.d.chen@xxxxxxxxx>

Acked-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux