Re: [PATCH] serial: clps711x: reworked driver version

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 11, 2012 at 07:51:29PM +0400, Alexander Shiyan wrote:
> This patch presents reworked version of CLPS711X serial driver.
> The changes from the old version:
> - Driver converted to platform_device.
> - Using CPU clock subsystem for getting base UART speed, since CPU can run
>   on different speeds.
> - Remove console_initcall and make console dynamically. Earler messages in
>   this case can be retrieved by using "earlyprintk" kernel option.
> - Using resource-managed functions (devm_xx).
> - Make all variables dynamically (reduce BSS).
> - Cleanup code & comments.

That's a lot of different things, all at once, making it very hard to
review.

Can you please break this up into the individual patches of what you are
doing above, one patch per thing, as is needed for Linux kernel patches?
That way it is much easier to accept and review.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux