On Tuesday 02 October 2012 05:17 PM, Alan Cox wrote: >> +/* Is this for UART emulation on ARC Instruction Set Simulator (ISS) >> */ +int __attribute__((weak)) running_on_iss; > Why not pass a quirks field in your platform data instead - much > cleaner than a global. I'd thought about it too. However the platform data is retrieved in arc_uart_init_one() while it's usage in arc_serial_set_termios() will be in a different call chain, meaning this info will have to be anyways saved in "some" data structure - probably within struct arc_uart_port - and that too per port - which is not clean either. However if you strongly feel that the global is a must go - I can rework it that way. thx, -Vineet -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
